This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Conversation
zpChris
approved these changes
Aug 3, 2020
Contributor
zpChris
left a comment
zpChris
left a comment
There was a problem hiding this comment.
LGTM, but leaving two notes:
- You should change all instances of
tripDayOfTraveltotripStartDateto indicate that the variable does not represent the sole travel date anymore. - Right now, adding the "Trip End Date" input field makes the "Next" button go onto the following line. Eventually, we'll want to prevent this from happening. In the UnifySiteDesign branch, the width of the site is wider and should allow this input form without pushing "Next" to a new line, but we should verify that this is indeed the case when the CLs are merged.
bootsieh
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL enables the user to enter an end date and stores that end date as part of the Trip entity in Datastore.
Note: This CL currently does not incorporate checks for valid input (that the endDate falls after the startDate, etc.). I have discussed the implementation of this with Chris and plan to incorporate this in a future CL. I also didn't include any styling for the endDate box because I'm waiting for the
UnifySiteDesignbranch to be merged.